Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9B5B310724 for ; Sun, 16 Jun 2013 00:03:20 +0000 (UTC) Received: (qmail 15020 invoked by uid 500); 16 Jun 2013 00:03:20 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 14979 invoked by uid 500); 16 Jun 2013 00:03:20 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 14971 invoked by uid 99); 16 Jun 2013 00:03:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Jun 2013 00:03:20 +0000 Date: Sun, 16 Jun 2013 00:03:20 +0000 (UTC) From: "Karthik Kambatla (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Kambatla updated MAPREDUCE-5213: ---------------------------------------- Attachment: mr-5213-1.patch As per discussion on MAPREDUCE-5275, the methods in TokenCache were introduced only to maintain compatibility against Hadoop-1. These methods were originally intended to be private. Moreover, they aren't used anywhere else in the code. In addition to marking them @Private, we should deprecate them to ensure they can be remove in subsequent major releases. Uploading a trivial patch that does that. > Re-assess TokenCache methods marked @Private > -------------------------------------------- > > Key: MAPREDUCE-5213 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213 > Project: Hadoop Map/Reduce > Issue Type: Bug > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Attachments: mr-5213-1.patch > > > While looking at the source, noticed that TokenCache#loadTokens methods are marked @Private but not used anywhere. > We should either remove those methods or mark them Public or LimitedPrivate. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira