hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranay Varma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5342) There are methods that should be deprecated and new methods should be added with names matching purposes
Date Sun, 23 Jun 2013 04:49:20 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691348#comment-13691348
] 

Pranay Varma commented on MAPREDUCE-5342:
-----------------------------------------

I think the goal should be to refactor and correct mistakes as time goes on. While it is a
noble goal to not break existing apps, it is also a noble goal to make it easier and intuitive
for those who are going to use it afresh. Java itself has moved towards such a goal by deprecating
methods that needed to be enhanced. Hadoop has deprecated quite a few methods as well. All
Job constructors are deprecated. 
                
> There are methods that should be deprecated and new methods should be added with names
matching purposes
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5342
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5342
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 2.1.0-beta, 2.0.5-alpha
>         Environment: Does not matter
>            Reporter: Pranay Varma
>
> ClusterStatus class has the following methods that need to be deprecated and new methods
added:
> getMapTasks does not return map tasks, it returns the number of map tasks.
> * getBlacklistedTrackers -> getNumBlacklistedTrackers
> * getMapTasks -> getNumMapTasks
> * getReduceTasks -> getNumReduceTasks
> * getTaskTrackers -> getNumTaskTrackers
> Cluster class needs the following change:
> There is a ClusterStatus class. When getClusterStatus is called, one would expect ClusterStatus
to be returned. Instead, one gets ClusterMetrics. 
> * getClusterStatus -> getClusterMetrics
> Job class has the following methods that need to be deprecated and new methods added
to match the purposes:
> mapProgress suggests that the method is going to map progress and is misleading because,
in fact, the method provides progress information about map tasks. It should be deprecated
and a method should be added with a name that matches the purpose: getMapTasksProgress or
getMapProgress.
> * mapProgress -> getMapProgress
> * reduceProgress -> getReduceProgress
> * cleanupProgress -> getCleanupProgress
> JobStatus:
> * getQueue -> getQueueName

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message