hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi OZAWA (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-5295) ShuffleConsumerPlugin.Context should remove unused combiner-related methods and fields
Date Fri, 07 Jun 2013 06:52:22 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tsuyoshi OZAWA updated MAPREDUCE-5295:
--------------------------------------

    Status: Open  (was: Patch Available)

Thank you for review, Mariappan.

The next patch removes combiner argument from the constructor and getCombinerClass() method
from the class, because it's never called from anywhare. It depends on MAPREDUCE-5294 so this
ticket is blocked by MAPREUDCE-5294.

                
> ShuffleConsumerPlugin.Context should remove unused combiner-related methods and fields
> --------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5295
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5295
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>    Affects Versions: trunk, 2.1.0-beta, 2.0.5-alpha
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: MAPREDUCE-5295.1.patch, MAPREDUCE-5295.2.patch
>
>
> ShuffleConsumerPlugin.Context only supports org.apache.hadoop.mapred.Reducer currently.
Because of this, Reduce side Combiner is not used when using the new API, and just ignored.
Please see MAPREDUCE-5221 for more detail.
> (Update Jun. 7th,  2013)  The latest version of MergeManagerImpl in MAPREDUCE-5294 never
calls ShuffleConsumerPlugin.Context#getCombinerClass() as [~masokan] pointed out. Because
of this, combinerClass field and getCombinerClass() method should be removed from ShuffleConsumerPlugin.Context.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message