hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-5213) Re-assess TokenCache methods marked @Private
Date Sun, 16 Jun 2013 00:03:20 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Karthik Kambatla updated MAPREDUCE-5213:
----------------------------------------

    Attachment: mr-5213-1.patch

As per discussion on MAPREDUCE-5275, the methods in TokenCache were introduced only to maintain
compatibility against Hadoop-1. These methods were originally intended to be private. Moreover,
they aren't used anywhere else in the code.

In addition to marking them @Private, we should deprecate them to ensure they can be remove
in subsequent major releases. Uploading a trivial patch that does that.
                
> Re-assess TokenCache methods marked @Private
> --------------------------------------------
>
>                 Key: MAPREDUCE-5213
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5213
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: mr-5213-1.patch
>
>
> While looking at the source, noticed that TokenCache#loadTokens methods are marked @Private
but not used anywhere. 
> We should either remove those methods or mark them Public or LimitedPrivate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message