Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Wed, 29 May 2013 20:44:20 +0000 (UTC)
From: "Mayank Bansal (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12646851.1368129780510.37617.1369860260624@arcas>
In-Reply-To: <JIRA.12646851.1368129780510@arcas>
References: <JIRA.12646851.1368129780510@arcas>
Subject: [jira] [Commented] (MAPREDUCE-5228) Enum Counter is removed from
 FileInputFormat and FileOutputFormat of both mapred and mapreduce
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669718#comment-13669718 ] 

Mayank Bansal commented on MAPREDUCE-5228:
------------------------------------------

Thanks [~vinodkv] for the review.

As discussed, I will file followup JIRA for 
>>>The logic can be per-counter instead of per-group. That way, even MAP_INPUT_BYTES can be handled the same way. May be later.

Rest of the comments are incorporated in the latest patch.

Thanks,
Mayank
                
> Enum Counter is removed from FileInputFormat and FileOutputFormat of both mapred and mapreduce
> ----------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5228
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5228
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Mayank Bansal
>         Attachments: MAPREDUCE-5228-trunk-1.patch, MAPREDUCE-5228-trunk-2.patch, MAPREDUCE-5228-trunk-3.patch
>
>
> The enum was used by findCounter(Enum key) to find a specific counter object. Now it seems to be replaced by FileInputFormatCounter and FileOutputFormatCounter. Now the enum seems to be only used internally, but not sure whether it will be used externally when users extend FileXXXXFormat.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira