hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mostafa Elhemali (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5224) JobTracker should allow the system directory to be in non-default FS
Date Thu, 23 May 2013 21:51:21 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665723#comment-13665723
] 

Mostafa Elhemali commented on MAPREDUCE-5224:
---------------------------------------------

Looks good to me. Some small comments mostly about the unit test:
# You don't have to catch(Exception) to call tearDown(), nor to print stack trace. tearDown()
will always be called automatically, and the exception will be displayed by the test framework.
Please remove the try..catch.
# Use assertTrue(cond) instead of assertEquals(cond, true)
# Even though this is a patch for branch-1-win, since it's a new test you should consider
writing it in JUnit 4. See [http://wiki.apache.org/hadoop/HowToDevelopUnitTests] for guidance.

Other than that, +1 on my side.
                
> JobTracker should allow the system directory to be in non-default FS
> --------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5224
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5224
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>            Reporter: Xi Fang
>            Assignee: Xi Fang
>            Priority: Minor
>             Fix For: 1-win
>
>         Attachments: MAPREDUCE-5224.2.patch, MAPREDUCE-5224.3.patch, MAPREDUCE-5224.patch
>
>
>  JobTracker today expects the system directory to be in the default file system
>         if (fs == null) {
>           fs = mrOwner.doAs(new PrivilegedExceptionAction<FileSystem>() {
>             public FileSystem run() throws IOException {
>               return FileSystem.get(conf);
>           }});
>         }
> ...
>   public String getSystemDir() {
>     Path sysDir = new Path(conf.get("mapred.system.dir", "/tmp/hadoop/mapred/system"));
 
>     return fs.makeQualified(sysDir).toString();
>   }
> In Cloud like Azure the default file system is set as ASV (Windows Azure Blob Storage),
but we would still like the system directory to be in DFS. We should change JobTracker to
allow that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message