Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9F2C6FB2C for ; Mon, 22 Apr 2013 18:19:18 +0000 (UTC) Received: (qmail 78501 invoked by uid 500); 22 Apr 2013 18:19:18 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 78456 invoked by uid 500); 22 Apr 2013 18:19:18 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 78406 invoked by uid 99); 22 Apr 2013 18:19:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Apr 2013 18:19:18 +0000 Date: Mon, 22 Apr 2013 18:19:18 +0000 (UTC) From: "Robert Joseph Evans (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-5069) add concrete common implementations of CombineFileInputFormat MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638269#comment-13638269 ] Robert Joseph Evans commented on MAPREDUCE-5069: ------------------------------------------------ I took a quick look at this and the code seems fine. I want to dig into it in more detail to be sure I understand exactly what is happening. > add concrete common implementations of CombineFileInputFormat > ------------------------------------------------------------- > > Key: MAPREDUCE-5069 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5069 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv1, mrv2 > Affects Versions: 2.0.3-alpha > Reporter: Sangjin Lee > Priority: Minor > Attachments: MAPREDUCE-5069-1.patch, MAPREDUCE-5069-2.patch, MAPREDUCE-5069-3.patch, MAPREDUCE-5069-4.patch, MAPREDUCE-5069-5.patch, MAPREDUCE-5069.patch > > > CombineFileInputFormat is abstract, and its specific equivalents to TextInputFormat, SequenceFileInputFormat, etc. are currently not in the hadoop code base. > These sound like very common need wherever CombineFileInputFormat is used, and different folks would write the same code over and over to achieve the same goal. It sounds very natural for hadoop to provide at least the text and sequence file implementations of the CombineFileInputFormat class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira