Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Mon, 15 Apr 2013 17:42:16 +0000 (UTC)
From: "Robert Joseph Evans (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12630628.1359980753893.168409.1366047736375@arcas>
In-Reply-To: <JIRA.12630628.1359980753893@arcas>
References: <JIRA.12630628.1359980753893@arcas>
Subject: [jira] [Commented] (MAPREDUCE-4974) Optimising the LineRecordReader
 initialize() method
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-4974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631916#comment-13631916 ] 

Robert Joseph Evans commented on MAPREDUCE-4974:
------------------------------------------------

The code changes look fine to me too, but I want to run a few more tests than the precommit build does.  I just don't want to have to pull it out yet again.
                
> Optimising the LineRecordReader initialize() method
> ---------------------------------------------------
>
>                 Key: MAPREDUCE-4974
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4974
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv1, mrv2, performance
>    Affects Versions: 2.0.2-alpha, 0.23.5
>         Environment: Hadoop Linux
>            Reporter: Arun A K
>            Assignee: Gelesh
>              Labels: patch, performance
>             Fix For: 0.23.7, 2.0.5-beta
>
>         Attachments: MAPREDUCE-4974.2.patch, MAPREDUCE-4974.3.patch, MAPREDUCE-4974.4.patch, MAPREDUCE-4974.5.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I found there is a a scope of optimizing the code, over initialize() if we have compressionCodecs & codec instantiated only if its a compressed input.
> Mean while Gelesh George Omathil, added if we could avoid the null check of key & value. This would time save, since for every next key value generation, null check is done. The intention being to instantiate only once and avoid NPE as well. Hope both could be met if initialize key & value over  initialize() method. We both have worked on it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira