Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Wed, 24 Apr 2013 17:45:16 +0000 (UTC)
From: "Arun C Murthy (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12610942.1349768736057.217500.1366825516342@arcas>
In-Reply-To: <JIRA.12610942.1349768736057@arcas>
References: <JIRA.12610942.1349768736057@arcas>
Subject: [jira] [Updated] (MAPREDUCE-4737)  Hadoop does not close output
 file / does not call Mapper.cleanup if exception in map
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MAPREDUCE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated MAPREDUCE-4737:
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.5-beta
                   1-win
                   1.2.0
     Release Note: Ensure that mapreduce APIs are semantically consistent with mapred API w.r.t Mapper.cleanup and Reducer.cleanup; in the sense that cleanup is now called even if there is an error. The old mapred API already ensures that Mapper.close and Reducer.close are invoked during error handling. Note that it is an incompatible change, however end-users can override Mapper.run and Reducer.run to get the old (inconsistent) behaviour.
     Hadoop Flags: Incompatible change,Reviewed
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks [~cnauroth] & [~tomwhite] for the reviews!
                
>  Hadoop does not close output file / does not call Mapper.cleanup if exception in map
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4737
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4737
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 1-win, 2.0.3-alpha, 1.1.2
>            Reporter: Daniel Dai
>            Assignee: Arun C Murthy
>             Fix For: 1.2.0, 1-win, 2.0.5-beta
>
>         Attachments: HADOOP-23-2.patch, HADOOP-8904-1.patch, MAPREDUCE-4737_branch1.patch, MAPREDUCE-4737_branch1.patch, MAPREDUCE-4737.patch, MAPREDUCE-4737.patch, MAPREDUCE-4737.patch
>
>
> Find this in Pig unit test TestStore under Windows. There are dangling files because map does not close the file when exception happens in map(). In Windows, Hadoop will not remove a file if it is not closed. This happens in reduce() as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira