hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jingguo Yao (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-5190) Unnecessary condition test in RandomSampler
Date Sat, 27 Apr 2013 14:18:15 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jingguo Yao updated MAPREDUCE-5190:
-----------------------------------

    Attachment: MAPREDUCE-5190.patch
    
> Unnecessary condition test in RandomSampler
> -------------------------------------------
>
>                 Key: MAPREDUCE-5190
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5190
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv1
>    Affects Versions: 1.0.4
>            Reporter: Jingguo Yao
>            Assignee: Jingguo Yao
>            Priority: Minor
>         Attachments: MAPREDUCE-5190.patch
>
>   Original Estimate: 20m
>  Remaining Estimate: 20m
>
> In getSampe method, there is a condition test after "int ind = r.nextInt(numSamples);".
The test is "(ind != numSamples)".
> This test is unneeded since nextInt(numSamples) will not return numSamples.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message