hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5152) MR App is not using Container from RM
Date Thu, 18 Apr 2013 19:12:13 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635546#comment-13635546
] 

Bikas Saha commented on MAPREDUCE-5152:
---------------------------------------

+1 overall. Minor nits
Reuse TA.getNodeId() instead of duplicating code?
{code}
-        + "] using containerId: [" + containerID + " on NM: ["
-        + containerMgrAddress + "]");
+        + "] using containerId: [" + container.getId() + " on NM: ["
+        + StringInterner.weakIntern(container.getNodeId().toString()) + "]");
{code}
{code}
-          taskAttempt.containerID, taskAttempt.containerMgrAddress,
-          taskAttempt.containerToken,
+          taskAttempt.container.getId(), StringInterner
+              .weakIntern(taskAttempt.container.getNodeId().toString()),
{code}

Unnecessary variable?
{code}
+      Container container = cEvent.getContainer();
+      taskAttempt.container = container;
{code}

Looks like there is still some avoidable copying happening in ContainerRemoteLauchEvent and
its base and in ContainerLaunchImpl.Container but we may leave it for a later date.
                
> MR App is not using Container from RM
> -------------------------------------
>
>                 Key: MAPREDUCE-5152
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5152
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.0.5-beta
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Vinod Kumar Vavilapalli
>         Attachments: MAPREDUCE-5152-20130415.1.txt, MAPREDUCE-5152-20130415.txt, MAPREDUCE-5152-20130417.txt
>
>
> The goal of YARN-486 was to make AMs just pass information encapsulated in Container
along to NM instead of doing it themselves by duplicating information. We still do not do
this pass-through as intended as YARN-486 avoided the individual field duplication but failed
to avoid the duplication of container itself.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message