hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5131) Provide better handling of job status related apis during JT restart
Date Fri, 05 Apr 2013 17:27:15 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623818#comment-13623818
] 

Karthik Kambatla commented on MAPREDUCE-5131:
---------------------------------------------

The second patch definitely looks good. Thanks Arun.

Minor comments:
# JobTracker#setInitDone() shouldn't need to take any parameter, no? Currently, it is only
the test using it, but this can change.
# JobTracker#waitForInit() shouldn't we do something when we catch the InterruptedException
- at the least, logging it might help
# JobTracker#waitForInit() - adding a log message that we are about to wait should help
# RetryUtils#getDefaultRetryPolicy() - break after setting found?
                
> Provide better handling of job status related apis during JT restart
> --------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5131
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5131
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>         Attachments: MAPREDUCE-5131.patch, MAPREDUCE-5131.patch
>
>
> I've seen pig/hive applications bork during JT restart since they get NPEs - this is
due to fact that jobs are not really inited, but are submitted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message