hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5121) Problem with field separator in FieldSelectionHelper
Date Mon, 01 Apr 2013 05:45:31 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618627#comment-13618627
] 

Hadoop QA commented on MAPREDUCE-5121:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12576340/MAPREDUCE-5121.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3489//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3489//console

This message is automatically generated.
                
> Problem with field separator in FieldSelectionHelper
> ----------------------------------------------------
>
>                 Key: MAPREDUCE-5121
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5121
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 1.0.4
>            Reporter: Kai Wei
>            Priority: Trivial
>         Attachments: MAPREDUCE-5121.patch
>
>
> I found that org.apache.hadoop.mapreduce.lib.fieldsel.FieldSelectionHelper and the corresponding
old api org.apache.hadoop.mapred.lib.FieldSelectionMapReduce take user specified separator
string as a regular expression in String.split(), but also use it as a normal string in StringBuffer.append().
It will be a problem if the separator string contains meta character. I suggest take separator
literally by calling Pattern.quote(separator). Or just use another property to specify the
separator which should be added in the output.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message