hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikas Saha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4987) TestMRJobs#testDistributedCache fails on Windows due to unexpected behavior of symlinks
Date Thu, 18 Apr 2013 23:29:16 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635825#comment-13635825
] 

Bikas Saha commented on MAPREDUCE-4987:
---------------------------------------

I thought that static blocks are executed once per class loader. So I am not sure why this
one would be executed per inner class object creation. In any case, moving the code to @BeforeClass
is a right thing to do in general.

Are the test times similar in Linux and Windows or they are close to timing out only on Windows.
I would be wary of simply doubling the test timeouts.

this probably can be done once instead of multiple times right? I am assuming this is a slow
filesystem operation.
{code}
+            if (new File(entry.getKey().toUri().getPath()).isDirectory()) { <---- THIS
+              newClassPath.append(Path.SEPARATOR);
+            }
{code}

btw, there doesnt seem to be a test about explicitly adding local resources to the classpath
in this patch, right?

Finally, this will have to be split into common, mr and yarn jiras+patches, though we will
need a combined patch to get a successful jenkins run. we can attach the combined patch to
the common jira because that will be committed first.

                
> TestMRJobs#testDistributedCache fails on Windows due to unexpected behavior of symlinks
> ---------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4987
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4987
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: distributed-cache, nodemanager
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: MAPREDUCE-4987.1.patch, MAPREDUCE-4987.2.patch, MAPREDUCE-4987.3.patch,
MAPREDUCE-4987.4.patch, MAPREDUCE-4987.5.patch
>
>
> On Windows, {{TestMRJobs#testDistributedCache}} fails on an assertion while checking
the length of a symlink.  It expects to see the length of the target of the symlink, but Java
6 on Windows always reports that a symlink has length 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message