hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3502) Review all Service.stop() operations and make sure that they work before a service is started
Date Wed, 03 Apr 2013 14:59:15 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620973#comment-13620973

Steve Loughran commented on MAPREDUCE-3502:

ignore that last comment -pasted into wrong issue-
> Review all Service.stop() operations and make sure that they work before a service is
> ---------------------------------------------------------------------------------------------
>                 Key: MAPREDUCE-3502
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3502
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: mrv2
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: MAPREDUCE-3502.patch, MAPREDUCE-3502.patch
>   Original Estimate: 24h
>          Time Spent: 2.5h
>  Remaining Estimate: 21.5h
> MAPREDUCE-3431 has shown that some of the key services's shutdown operations are not
robust against being invoked before the service is started. They need to be by
> # not calling other things if the other things are null
> # not being re-entrant (i.e. make synchronized if possible), 
> Maybe 
> # have a StopService operation that only stops a service if it is live
> # factor out the is-running test from the base service class and make it a pre-check
for all the child services, so they bail out sooner rather than later. This would be the best
as it would be the one guaranteed to work consistently across all instances, so only one or
two would need testing
> my first iteration will skip the sync though it's something to consider. 
> Testing: try to create each instance; call stop() straight after construction. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message