hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5086) MR app master deletes staging dir when sent a reboot command from the RM
Date Mon, 25 Mar 2013 14:57:16 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612691#comment-13612691

Jason Lowe commented on MAPREDUCE-5086:

Couple of comments after a quick look at the patch:

* seems like a hack to change the signature of shutDownJob to take a JobImpl.  There's already
a createJob method intended to be overridden for testing
* also seems like a hack to downcast to JobImpl for this.  If we're going to ignore the Job
interface, why is {{job}} not just declared JobImpl?  Or should we really be extending the
Job interface, or is there a better way?
* Still unnecessary whitespace changes in the patch
> MR app master deletes staging dir when sent a reboot command from the RM
> ------------------------------------------------------------------------
>                 Key: MAPREDUCE-5086
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5086
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: jian he
>            Assignee: jian he
>         Attachments: YARN-472.1.patch, YARN-472.2.patch, YARN-472.3.patch, YARN-472.4.patch
> If the RM is restarted when the MR job is running, then it sends a reboot command to
the job. The job ends up deleting the staging dir and that causes the next attempt to fail.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message