hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4875) coverage fixing for org.apache.hadoop.mapred
Date Wed, 20 Mar 2013 15:55:21 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607758#comment-13607758
] 

Robert Joseph Evans commented on MAPREDUCE-4875:
------------------------------------------------

Yes, TaskLog was the big one that I saw no reason to test.

Of those I feel fine with you removing

TaskLog#*
QueueManager#* (we should probably file a JIRA to look into removing the class entirely and
refactoring as needed)
JvmTask#*
JobEndNotifier#* (we shoudl probably also file a JIRA to look at removing the class and refactoring
it to combine with org.apache.hadoop.mapreduce.v2.app.JobEndNotifier)
TaskStatus#*

Possibly 

CleanupQueue#*

I think CleanupQueue is going to be OK to remove, but it is not marked as @Private so it makes
me more nervous.

But I would hold off on the rest.
                
> coverage fixing for org.apache.hadoop.mapred
> --------------------------------------------
>
>                 Key: MAPREDUCE-4875
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4875
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
>            Reporter: Aleksey Gorshkov
>             Fix For: 3.0.0, 0.23.6, 2.0.5-beta
>
>         Attachments: MAPREDUCE-4875-branch-0.23.patch, MAPREDUCE-4875-trunk.patch
>
>
> added  some tests for org.apache.hadoop.mapred
> MAPREDUCE-4875-trunk.patch for trunk and branch-2
> MAPREDUCE-4875-branch-0.23.patch for branch-0.23

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message