hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4964) JobLocalizer#localizeJobFiles can potentially write job.xml to the wrong user's directory
Date Fri, 01 Feb 2013 23:02:13 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569210#comment-13569210
] 

Karthik Kambatla commented on MAPREDUCE-4964:
---------------------------------------------

Arun, 

I agree this JIRA is a (unintentional) duplicate of MAPREDUCE-4843. I believe the fix posted
here is a cleaner/simpler solution to (1) fix the DiskChecker errors we have been seeing,
and (2) JobLocalizer thread-safety in the context of all accesses including DefaultTaskController.

Thanks for your insights.
                
> JobLocalizer#localizeJobFiles can potentially write job.xml to the wrong user's directory
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4964
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4964
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1
>    Affects Versions: 1.1.1
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: MR-4964.patch, MR-4964.patch
>
>
> In the following code, if jobs corresponding to different users (X and Y) are localized
simultaneously, it is possible that jobconf can be written to the wrong user's directory.
(X's job.xml can be written to Y's directory)
> {code}
>   public void localizeJobFiles(JobID jobid, JobConf jConf,
>       Path localJobTokenFile, TaskUmbilicalProtocol taskTracker)
>       throws IOException, InterruptedException {
>     localizeJobFiles(jobid, jConf,
>         lDirAlloc.getLocalPathForWrite(JOBCONF, ttConf), localJobTokenFile,
>         taskTracker);
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message