hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4846) Some JobQueueInfo methods are public in MR1 but protected in MR2
Date Thu, 21 Feb 2013 11:46:13 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583126#comment-13583126
] 

Hudson commented on MAPREDUCE-4846:
-----------------------------------

Integrated in Hadoop-trunk-Commit #3370 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3370/])
    MAPREDUCE-4846. Some JobQueueInfo methods are public in MR1 but protected in MR2. Contributed
by Sandy Ryza. (Revision 1448597)

     Result = SUCCESS
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1448597
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobQueueInfo.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/QueueConfigurationParser.java

                
> Some JobQueueInfo methods are public in MR1 but protected in MR2
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-4846
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4846
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>             Fix For: 2.0.4-beta
>
>         Attachments: MAPREDUCE-4846-1.patch, MAPREDUCE-4846-1.patch, MAPREDUCE-4846.patch
>
>
> setQueueName, setSchedulingInfo, and setQueueState were public in MR1, but are private
int MR2.  They should be made public with InterfaceAudience.Private.
> getQueueState was public, but is now package private.  It has been replaced with getState,
which returns a QueueState instead of a String.  It should be made public and deprecated,
with a documentation reference to getState.
> Should the other setter methods in JobQueueInfo that were not in MR1 be changed to public/InterfaceAudience.Private
for consistency?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message