hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-4936) JobImpl uber checks for cpu are wrong
Date Tue, 15 Jan 2013 14:50:14 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-4936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Lowe updated MAPREDUCE-4936:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.3-alpha
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks, Arun!  I committed this to trunk and branch-2.
                
> JobImpl uber checks for cpu are wrong
> -------------------------------------
>
>                 Key: MAPREDUCE-4936
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4936
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.0.3-alpha
>            Reporter: Daryn Sharp
>            Assignee: Arun C Murthy
>            Priority: Critical
>             Fix For: 2.0.3-alpha
>
>         Attachments: MAPREDUCE-4936.patch
>
>
> The cpu checks for uberizing have two issues:
> # the defaults are hardcoded instead of using the conf defaults
> # the comparison against the sys cpu size is using {{<}} instead of {{<=}}
> {code}
>     boolean smallCpu =
>         (
>             Math.max(
>                 conf.getInt(MRJobConfig.MAP_CPU_VCORES, 1), 
>                 conf.getInt(MRJobConfig.REDUCE_CPU_VCORES, 1)) < 
>              sysCPUSizeForUberSlot
>         );
> {code}
> Everything is defaulting to 1, so uber cpu checks are now disabled causing {{TestUberAM}}
to fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message