hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Surenkumar Nihalani (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4925) Backport MAPREDUCE-4678 to branch-1
Date Tue, 08 Jan 2013 09:16:15 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546722#comment-13546722
] 

Surenkumar Nihalani commented on MAPREDUCE-4925:
------------------------------------------------

I was reviewing the patch and 
{code:title=m4-4295.patch.java|borderStyle=solid}
+    for (int i = 0; i < args.length; i++) {
+      if (args[i].equalsIgnoreCase("-depth")) {
+        depth = Integer.parseInt(args[i++].trim());
+      } else if (args[i].equalsIgnoreCase("-height")) {
+        height = Integer.parseInt(args[i++].trim());
+      } else if (args[i].equalsIgnoreCase("-width")) {
+        width = Integer.parseInt(args[i++].trim());
+      }
+    }
{code}

I don't think this works. I believe we need to access the parameters like {{args[++i]}} instead
of {{args[i++]}}
Can you confirm this worked?
                
> Backport MAPREDUCE-4678 to branch-1
> -----------------------------------
>
>                 Key: MAPREDUCE-4925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: examples
>    Affects Versions: 1.1.1
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: mr-4925.patch
>
>
> MAPREDUCE-4678 adds an easier way to specify arguments to Pentomino. This JIRA is for
branch-1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message