Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Tue, 11 Dec 2012 17:41:21 +0000 (UTC)
From: "Chris Nauroth (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12623409.1355246049461.18759.1355247681264@arcas>
In-Reply-To: <JIRA.12623409.1355246049461@arcas>
References: <JIRA.12623409.1355246049461@arcas>
Subject: [jira] [Updated] (MAPREDUCE-4870) TestMRJobsWithHistoryService
 causes infinite loop if it fails
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MAPREDUCE-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated MAPREDUCE-4870:
-------------------------------------

    Attachment: MAPREDUCE-4870.1.patch

I noticed this problem on Windows, where the test currently fails.  The attached patch changes the test to poll for any of the terminal states: {{RMAppState.FINISHED}}, {{RMAppState.FAILED}}, or {{RMAppState.KILLED}}.  Those are all of the terminal states, right?  After the loop, I added an assertion that it was {{RMAppState.FINISHED}}.  For extra safety, I also aborted the polling loop after a maximum of 60 seconds.

The test still fails on Windows on the new assertion.  We'll need to fix that later, but for right now, I just want to fix the infinite loop, which tends to ruin entire project test runs.

This patch can commit to trunk and then merge to branch-trunk-win.

                
> TestMRJobsWithHistoryService causes infinite loop if it fails
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-4870
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4870
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0, trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: MAPREDUCE-4870.1.patch
>
>
> {{TestMRJobsWithHistoryService#testJobHistoryData}} has a periodic poll and sleep after job execution, checking for the application state to reach {{RMAppState#FINISHED}}.  If the job fails, then the application could be in a different terminal state, and this polling loop will never terminate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira