hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-4870) TestMRJobsWithHistoryService causes infinite loop if it fails
Date Tue, 11 Dec 2012 17:41:21 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Chris Nauroth updated MAPREDUCE-4870:

    Attachment: MAPREDUCE-4870.1.patch

I noticed this problem on Windows, where the test currently fails.  The attached patch changes
the test to poll for any of the terminal states: {{RMAppState.FINISHED}}, {{RMAppState.FAILED}},
or {{RMAppState.KILLED}}.  Those are all of the terminal states, right?  After the loop, I
added an assertion that it was {{RMAppState.FINISHED}}.  For extra safety, I also aborted
the polling loop after a maximum of 60 seconds.

The test still fails on Windows on the new assertion.  We'll need to fix that later, but for
right now, I just want to fix the infinite loop, which tends to ruin entire project test runs.

This patch can commit to trunk and then merge to branch-trunk-win.

> TestMRJobsWithHistoryService causes infinite loop if it fails
> -------------------------------------------------------------
>                 Key: MAPREDUCE-4870
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4870
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0, trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: MAPREDUCE-4870.1.patch
> {{TestMRJobsWithHistoryService#testJobHistoryData}} has a periodic poll and sleep after
job execution, checking for the application state to reach {{RMAppState#FINISHED}}.  If the
job fails, then the application could be in a different terminal state, and this polling loop
will never terminate.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message