hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4594) Add init/shutdown methods to mapreduce Partitioner
Date Thu, 06 Dec 2012 18:15:10 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511578#comment-13511578
] 

Hadoop QA commented on MAPREDUCE-4594:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12556382/partitioner2.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3102//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3102//console

This message is automatically generated.
                
> Add init/shutdown methods to mapreduce Partitioner
> --------------------------------------------------
>
>                 Key: MAPREDUCE-4594
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4594
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: trunk
>            Reporter: Radim Kolar
>         Attachments: partitioner1.txt, partitioner2.txt
>
>
> The Partitioner supports only the Configurable API, which can be used for basic init
in setConf(). Problem is that there is no shutdown function.
> I propose to use standard setup() cleanup() functions like in mapper / reducer.
> Use case is that I need to start and stop spring context and datagrid client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message