hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandy Ryza (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-4846) Some JobQueueInfo methods are public in MR1 but protected in MR2
Date Wed, 05 Dec 2012 00:42:58 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sandy Ryza updated MAPREDUCE-4846:
----------------------------------

    Description: 
setQueueName, setSchedulingInfo, and setQueueState were public in MR1, but are private int
MR2.  They should be made public with InterfaceAudience.Private.

getQueueState was public, but is now package private.  It has been replaced with getState,
which returns a QueueState instead of a String.  It should be made public and deprecated,
with a documentation reference to getState.

Should the other setter methods in JobQueueInfo that were not in MR1 be changed to public/InterfaceAudience.Private
for consistency?


  was:
setQueueName, setSchedulingInfo, and setQueueState were public in MR1, but are private int
MR2.  They should be made public with InterfaceAudience.Private.

getQueueState was public, but is now package private.  It has been replaced with getState,
which returns a QueueState instead of a String.  It should be made public and deprecated,
with a documentation reference to getState.


    
> Some JobQueueInfo methods are public in MR1 but protected in MR2
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-4846
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4846
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>
> setQueueName, setSchedulingInfo, and setQueueState were public in MR1, but are private
int MR2.  They should be made public with InterfaceAudience.Private.
> getQueueState was public, but is now package private.  It has been replaced with getState,
which returns a QueueState instead of a String.  It should be made public and deprecated,
with a documentation reference to getState.
> Should the other setter methods in JobQueueInfo that were not in MR1 be changed to public/InterfaceAudience.Private
for consistency?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message