Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20756DAE1 for ; Thu, 1 Nov 2012 18:19:13 +0000 (UTC) Received: (qmail 71761 invoked by uid 500); 1 Nov 2012 18:19:12 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 71728 invoked by uid 500); 1 Nov 2012 18:19:12 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 71714 invoked by uid 99); 1 Nov 2012 18:19:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Nov 2012 18:19:12 +0000 Date: Thu, 1 Nov 2012 18:19:12 +0000 (UTC) From: "Ivan A. Veselovsky (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: <1564698170.57160.1351793952869.JavaMail.jiratomcat@arcas> In-Reply-To: <451921125.56755.1351788916566.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (MAPREDUCE-4764) repair test org.apache.hadoop.mapreduce.security.TestBinaryTokenFile MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488903#comment-13488903 ] Ivan A. Veselovsky commented on MAPREDUCE-4764: ----------------------------------------------- The failed test org.apache.hadoop.mapred.TestClusterMRNotification.testMR appears to be flaky: it fails in many previous pre-commit builds. Re-submitting the patch to try again. > repair test org.apache.hadoop.mapreduce.security.TestBinaryTokenFile > -------------------------------------------------------------------- > > Key: MAPREDUCE-4764 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4764 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Reporter: Ivan A. Veselovsky > Attachments: MAPREDUCE-4764-trunk.patch > > > the test is @Ignore-ed, and fails being enabled. > Suggested to repair it to fill the coverage gap. > Problems fixed in the test: > (1) MRConfig.FRAMEWORK_NAME and YarnConfiguration.RM_PRINCIPAL properties must be correctly set in the configuration to correctly enable the security in the way this test implies. > (2) The property MRJobConfig.MAPREDUCE_JOB_CREDENTIALS_BINARY now is not passed into the Job configuration -- it is intentionally deleted from there. So, we pass the binary file name in another dedicated property. > (3) The test was using deprecated cluster classes. All them are updated to the modern analogs. > (4) The delegation token found in the job context is now correctly compared to the one deserialized from the binary file. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira