hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4221) Remove jquery theming support
Date Tue, 13 Nov 2012 21:40:17 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496574#comment-13496574
] 

Jason Lowe commented on MAPREDUCE-4221:
---------------------------------------

Patch looks pretty good.  Besides Luke's comment, I think the following directories can also
be deleted as they appear to be specific to the theme switching support being removed:

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/jquery/themeswitcher-images
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/webapps/static/theme

I manually tested some pages with those also removed, and it seemed to be working fine.
                
> Remove jquery theming support
> -----------------------------
>
>                 Key: MAPREDUCE-4221
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4221
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: webapps
>    Affects Versions: 2.0.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Robert Joseph Evans
>              Labels: newbie
>         Attachments: MAPREDUCE-4221.patch, MAPREDUCE-4221.patch, MR-4221.sh, MR-4221.txt
>
>
> As of today we have 9.4MB of JQuery themes in our code tree. In addition to being a waste
of space, it's a highly questionable feature. I've never heard anyone complain that the Hadoop
interface isn't themeable enough, and there's far more value in consistency across installations
than there is in themeability. Let's rip it out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message