hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4782) NLineInputFormat skips first line of last InputSplit
Date Thu, 08 Nov 2012 22:36:12 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493571#comment-13493571
] 

Hadoop QA commented on MAPREDUCE-4782:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12552709/MR-4782.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

                  org.apache.hadoop.mapred.TestClusterMRNotification

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3000//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3000//console

This message is automatically generated.
                
> NLineInputFormat skips first line of last InputSplit
> ----------------------------------------------------
>
>                 Key: MAPREDUCE-4782
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4782
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.22.0, 0.23.0, 1.0.0, 2.0.0-alpha, trunk
>         Environment: job.setMapperClass(Mapper.class);  // just pass text lines through
to output
> job.setInputFormatClass(NLineInputFormat.class);
> NLineInputFormat.setNumLinesPerSplit(job, 100);
> NLineInputFormat.setInputPaths(job, "/path/to/a_file_with_many_lines.txt");
>            Reporter: Mark Fuhs
>            Priority: Critical
>         Attachments: MAPREDUCE-4782.patch, MR-4782.txt
>
>
> NLineInputFormat creates FileSplits that are then used by LineRecordReader to generate
Text values. To deal with an idiosyncrasy of LineRecordReader, the begin and length fields
of the FileSplit are constructed differently for the first FileSplit vs. the rest.
> After looping through all lines of a file, the final FileSplit is created, but the creation
does not respect the difference of how the first vs. the rest of the FileSplits are created.
> This results in the first line of the final InputSplit being skipped. I've created a
patch to NLineInputFormat, and this fixes the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message