hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4812) Create reduce input merger plugin in ReduceTask.java and pass it to Shuffle
Date Thu, 22 Nov 2012 20:36:58 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502925#comment-13502925
] 

Alejandro Abdelnur commented on MAPREDUCE-4812:
-----------------------------------------------

Analogous comments like in MAPREDUCE-4807. 

It looks good, you indicated you'd be creating a patch with a test. I'll wait for it for +1ing
it.

Minor naming nits:

* The property *mapreduce.job.reduce.merge.classs*, I think a better name would be *mapreduce.job.reduce.input.merger.classs*

* The ReduceMergerContext inner class, it could simply be called Context (as the outer class
 fully defines it)
                
> Create reduce input merger plugin in ReduceTask.java and pass it to Shuffle
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4812
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4812
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>    Affects Versions: 2.0.2-alpha
>            Reporter: Mariappan Asokan
>            Assignee: Mariappan Asokan
>             Fix For: 2.0.3-alpha
>
>         Attachments: mapreduce-4812.patch, mapreduce-4812.patch
>
>
> This is part of MAPREDUCE-2454.  This further breaks down MAPREDUCE-4808

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message