Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B6F7FD1DE for ; Wed, 24 Oct 2012 12:58:24 +0000 (UTC) Received: (qmail 17542 invoked by uid 500); 24 Oct 2012 12:58:23 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 17497 invoked by uid 500); 24 Oct 2012 12:58:23 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 17484 invoked by uid 99); 24 Oct 2012 12:58:23 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Oct 2012 12:58:23 +0000 Date: Wed, 24 Oct 2012 12:58:23 +0000 (UTC) From: "Hudson (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: <1529233366.21550.1351083503773.JavaMail.jiratomcat@arcas> In-Reply-To: <1074249202.29578.1336175268387.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (MAPREDUCE-4229) Counter names' memory usage can be decreased by interning MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483195#comment-13483195 ] Hudson commented on MAPREDUCE-4229: ----------------------------------- Integrated in Hadoop-Hdfs-trunk #1205 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1205/]) Updating credits for MAPREDUCE-4229. (Revision 1401493) MAPREDUCE-4229. Intern counter names in the JT (bobby via daryn) (Revision 1401473) MAPREDUCE-4229. Intern counter names in the JT (bobby via daryn) (Revision 1401467) Result = FAILURE daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401493 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401473 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringInterner.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringInterner.java daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401467 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventReader.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryParser.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/CountersStrings.java > Counter names' memory usage can be decreased by interning > --------------------------------------------------------- > > Key: MAPREDUCE-4229 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-4229 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: jobtracker > Affects Versions: 1.0.2, 3.0.0, 2.0.2-alpha > Reporter: Todd Lipcon > Assignee: Miomir Boljanovic > Fix For: 3.0.0, 2.0.3-alpha, 0.23.5 > > Attachments: MAPREDUCE-4229-branch-0.23.patch, MAPREDUCE-4229-branch-0.23.patch, MAPREDUCE-4229.patch, mr-4229.txt, MR-4229.txt > > > In our experience, most of the memory in production JTs goes to storing counter names (String objects and character arrays). Since most counter names are reused again and again, it would be a big memory savings to keep a hash set of already-used counter names within a job, and refer to the same object from all tasks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira