hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4707) Add a comment to explain why FairScheduler#dump()'s body is synchronized on eventLog
Date Fri, 05 Oct 2012 19:04:02 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470565#comment-13470565
] 

Karthik Kambatla commented on MAPREDUCE-4707:
---------------------------------------------

That said, wouldn't it be simpler to buffer all the dump log messages, and log them at once?
That way, other non-synchronized methods in FS wouldn't need to wait for dump to go through
all the jobs/pools.
                
> Add a comment to explain why FairScheduler#dump()'s body is synchronized on eventLog
> ------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4707
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4707
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Trivial
>         Attachments: MR-4707.patch, MR-4707.patch
>
>
> FairScheduler#dump() is a synchronized method. In addition to that, the entire method
body is in a synchronized block on eventLog. However, there is no other portion of the code
that tries to acquire a lock on eventLog. So, it seems like the second synchronized block
is redundant, and can be removed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message