hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4676) Add test for job history cleaner
Date Tue, 09 Oct 2012 16:30:03 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472519#comment-13472519
] 

Alejandro Abdelnur commented on MAPREDUCE-4676:
-----------------------------------------------

After looking at the code, it would quite difficult to mock things without a big refactoring.
Thus, I agree with Tom, I'd suggest to create a method with the old signature and use that
it the production code and have the method with the boolean param for testing with the @VisibleForTesting
annotation.
                
> Add test for job history cleaner
> --------------------------------
>
>                 Key: MAPREDUCE-4676
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4676
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver
>    Affects Versions: 1.0.3, 2.0.1-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-4676.patch, MAPREDUCE-4676-trunk.patch
>
>
> Add a test to TestJobHistory that verifies that the HistoryCleaner cleans up the job
history

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message