hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4574) Fix TotalOrderParitioner to work with non-WritableComparable key types
Date Tue, 09 Oct 2012 13:01:22 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472343#comment-13472343
] 

Hudson commented on MAPREDUCE-4574:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #1190 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1190/])
    MAPREDUCE-4574. Fix TotalOrderParitioner to work with non-WritableComparable key types.
Contributed by Harsh J. (harsh) (Revision 1395936)

     Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1395936
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/TotalOrderPartitioner.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/TotalOrderPartitioner.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/partition/TestTotalOrderPartitioner.java

                
> Fix TotalOrderParitioner to work with non-WritableComparable key types
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4574
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4574
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.0.0-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4574.patch, MAPREDUCE-4574.patch
>
>
> The current TotalOrderPartitioner class will not work with an alternative serialization
library such as Avro.
> To make it work, we may edit the readPartitions bits in it to support non-WritableComparable
keys and also remove the WritableComparable check in the class types definition.
> That is, since we do not use the values at all (NullWritable), we may as well do:
> {code}
>   private K[] readPartitions(FileSystem fs, Path p, Class<K> keyClass,
>       Configuration conf) throws IOException {
>     …
>     while ((key = (K) reader.next(key)) != null) {
>       parts.add(key);
>       key = ReflectionUtils.newInstance(keyClass, conf);
>     }
>     …
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message