hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4722) LocalJobRunner random ID should not be chosen with Math.abs(rand.nextInt())
Date Thu, 11 Oct 2012 18:37:03 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474417#comment-13474417
] 

Hadoop QA commented on MAPREDUCE-4722:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548789/MAPREDUCE-4722.patch
  against trunk revision .

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2925//console

This message is automatically generated.
                
> LocalJobRunner random ID should not be chosen with Math.abs(rand.nextInt())
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4722
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4722
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: job submission
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-4722.patch
>
>
> According to findbugs 2, this can cause problems if the randomly generated int is Integer.MIN_VALUE
because Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message