hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-4574) Fix TotalOrderParitioner to work with non-WritableComparable key types
Date Tue, 09 Oct 2012 10:00:03 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Harsh J updated MAPREDUCE-4574:
-------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks Doug! I went ahead and committed this to trunk.
                
> Fix TotalOrderParitioner to work with non-WritableComparable key types
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4574
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4574
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.0.0-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: MAPREDUCE-4574.patch, MAPREDUCE-4574.patch
>
>
> The current TotalOrderPartitioner class will not work with an alternative serialization
library such as Avro.
> To make it work, we may edit the readPartitions bits in it to support non-WritableComparable
keys and also remove the WritableComparable check in the class types definition.
> That is, since we do not use the values at all (NullWritable), we may as well do:
> {code}
>   private K[] readPartitions(FileSystem fs, Path p, Class<K> keyClass,
>       Configuration conf) throws IOException {
>     …
>     while ((key = (K) reader.next(key)) != null) {
>       parts.add(key);
>       key = ReflectionUtils.newInstance(keyClass, conf);
>     }
>     …
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message