hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4707) Add a comment to explain why FairScheduler#dump()'s body is synchronized on eventLog
Date Fri, 05 Oct 2012 18:52:04 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470556#comment-13470556

Hadoop QA commented on MAPREDUCE-4707:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2908//console

This message is automatically generated.
> Add a comment to explain why FairScheduler#dump()'s body is synchronized on eventLog
> ------------------------------------------------------------------------------------
>                 Key: MAPREDUCE-4707
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4707
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Trivial
>         Attachments: MR-4707.patch, MR-4707.patch
> FairScheduler#dump() is a synchronized method. In addition to that, the entire method
body is in a synchronized block on eventLog. However, there is no other portion of the code
that tries to acquire a lock on eventLog. So, it seems like the second synchronized block
is redundant, and can be removed.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message