hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4629) Remove JobHistory.DEBUG_MODE
Date Fri, 07 Sep 2012 16:36:07 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450765#comment-13450765
] 

Hadoop QA commented on MAPREDUCE-4629:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12544233/trunk-mr-6429.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2831//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2831//console

This message is automatically generated.
                
> Remove JobHistory.DEBUG_MODE
> ----------------------------
>
>                 Key: MAPREDUCE-4629
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4629
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: branch1-mr-4629.patch, MR-4629.patch, MR-4629.patch.v1, trunk-mr-6429.patch,
trunk-mr-6429.patch
>
>
> Remove JobHistory.DEBUG_MODE for the following reasons:
> 1. No one seems to be using it - the config parameter corresponding to enabling it does
not even exist in mapred-default.xml
> 2. The logging being done in DEBUG_MODE needs to move to LOG.debug() and LOG.trace()
> 3. Buggy handling of helper methods in DEBUG_MODE; e.g. directoryTime() and timestampDirectoryComponent().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message