hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Prakash (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4651) Benchmarking random reads with DFSIO
Date Thu, 13 Sep 2012 17:20:07 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455019#comment-13455019
] 

Ravi Prakash commented on MAPREDUCE-4651:
-----------------------------------------

Hi Konstantin,

Thanks for this initiative. I like the idea of benchmarking random reads. Some comments:
1. Why not label IOMapperBase.getIOStream() abstract rather than return null?
2. Some extra whitespaces.
3. TestDFSIO:doIO, @Override //IOMapperBase
4. In doIO(), would it make sense to do?
      if( this.stream instanceof InputStream) InputStream in = (InputStream)this.stream;
   Similarly for PositionedReadable
5. public RandomReadMapper()  you can use new Random(), to seed it with a distinct seed. You
don't need a call to System.nanoTime().

Oh, and could you please review MAPREDUCE-4645? =D
                
> Benchmarking random reads with DFSIO
> ------------------------------------
>
>                 Key: MAPREDUCE-4651
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4651
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>          Components: benchmarks, test
>    Affects Versions: 1.0.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: randomDFSIO.patch
>
>
> TestDFSIO measures throughput of HDFS write, read, and append operations. It will be
useful to have an option to use it for benchmarking random reads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message