hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariappan Asokan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-4470) Fix TestCombineFileInputFormat.testForEmptyFile
Date Tue, 14 Aug 2012 20:29:38 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Mariappan Asokan updated MAPREDUCE-4470:

    Attachment: TestFileInputFormat.java

Hi Ilya Katsov,
  Sorry, I was not able to get back ASAP since Jira was down.  I looked at the code for FileInputFormat.
 I am sorry, I misled you.  The method getLocations() in InputSplit CAN return a 0 length
array for an empty file since there is no physical block of storage associated with the file.
 I have attached the new version of TestFileInputFormat.java.  I feel that it is good to have
a test for an empty file since it tests a boundary condition.

-- Asokan
> Fix TestCombineFileInputFormat.testForEmptyFile
> -----------------------------------------------
>                 Key: MAPREDUCE-4470
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4470
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Kihwal Lee
>             Fix For: 2.1.0-alpha, 3.0.0
>         Attachments: MAPREDUCE-4470.patch, TestFileInputFormat.java, TestFileInputFormat.java
> TestCombineFileInputFormat.testForEmptyFile started failing after HADOOP-8599. 
> It expects one split on an empty input file, but with HADOOP-8599 it gets zero. The new
behavior seems correct, but is it breaking anything else?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message