hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4351) Make ContainersMonitor pluggable
Date Tue, 03 Jul 2012 21:00:45 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406046#comment-13406046
] 

Tom White commented on MAPREDUCE-4351:
--------------------------------------

Overall this looks like a reasonable refactor to me.

When the patch is committed we'll need a script that does 'svn mv' on the files that changed
names (e.g. ContainersMonitorImpl.java -> DefaultContainerExecutor.java), so that history
is preserved. This will be run before applying the patch. You can see how to do this at http://wiki.apache.org/hadoop/HowToContribute#Creating_a_patch,
under the bit that says "If you need to rename files in your patch". A patch generated this
way is also easier to review. However, Jenkins can't apply it so you might want to wait for
a clear Jenkins run first.

                
> Make ContainersMonitor pluggable
> --------------------------------
>
>                 Key: MAPREDUCE-4351
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4351
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, nodemanager
>            Reporter: Andrew Ferguson
>            Assignee: Andrew Ferguson
>         Attachments: MAPREDUCE-4351-v1.patch, MAPREDUCE-4351-v2.patch, MAPREDUCE-4351-v3.patch,
MAPREDUCE-4351-v4.patch, MAPREDUCE-4351-v4.patch, MAPREDUCE-4351-v5.patch, MAPREDUCE-4351-v5.patch,
MAPREDUCE-4351-v6.patch
>
>
> Make the existing ContainersManager pluggable, just as the ContainerExecutor is currently.
This will allow us to add container resource enforcement using other techniques (such as cgroups)
in an extensible fashion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message