hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ahmed Radwan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4422) YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
Date Fri, 13 Jul 2012 09:10:35 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413594#comment-13413594
] 

Ahmed Radwan commented on MAPREDUCE-4422:
-----------------------------------------

> the newly added variable DEFAULT_YARN_APPLICATION_CLASSPATH isn't being used anywhere?
The point of adding this was to use it, at least, in MRApps.setMRFrameworkClasspath?

MRApps.setMRFrameworkClasspath reads the value from the conf files through conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH),
and if not set, the default value will be picked from yarn-default.xml. Making it reads the
DEFAULT_YARN_APPLICATION_CLASSPATH will defeat the purpose of having it configurable. Or do
you just mean modifying the call to be conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH,
DEFAULT_YARN_APPLICATION_CLASSPATH), which will not make a difference in this case as the
default is already picked if the property is not set.

> we should use Configuration.getStrings rather than do a 'manual' String.split to parse
this out.

Configuration.getString uses StringTokenizer to achieve exactly what String.split will do
here. I am not sure if one is more efficient than the other, but I can change the it if you
know it is better. I'll upload a new patch with the updates.
                
> YARN_APPLICATION_CLASSPATH needs a documented default value in YarnConfiguration
> --------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4422
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 2.0.0-alpha
>            Reporter: Arun C Murthy
>            Assignee: Ahmed Radwan
>             Fix For: 2.0.1-alpha
>
>         Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message