hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4452) Several Findbugs issues with new FairScheduler in YARN
Date Wed, 18 Jul 2012 16:57:34 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417243#comment-13417243
] 

Karthik Kambatla commented on MAPREDUCE-4452:
---------------------------------------------

Thanks for the patch, Junping.

The patch definitely fixes the findbugs warnings. However, the patch converts all methods
reported by findbugs to synchronized. In cases where findbugs reports a false positive for
bugs, that might affect performance. It might be best to commit this patch, but create a separate
JIRA to de-synchronize methods. For every method we de-synchronize, we probably need a justification
(in comments) as to why it doesn't create a buggy scenario.



                
> Several Findbugs issues with new FairScheduler in YARN
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4452
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4452
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.1.0-alpha
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: MAPREDUCE-4452-v1.patch, MAPREDUCE-4452.patch
>
>
> The good feature of FairScheduler is added recently to YARN. As recently PreCommit test
from MAPREDUCE-4309, there are several bugs found by Findbugs related to FairScheduler:
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerEventLog.shutdown()
might ignore java.lang.Exception
> Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerEventLog.logDisabled;
locked 50% of time
> Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.queueMaxAppsDefault;
locked 50% of time
> Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.userMaxAppsDefault;
locked 50% of time
> The details are in:https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2612//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html#DE_MIGHT_IGNORE


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message