Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 60D4E9908 for ; Mon, 25 Jun 2012 22:22:46 +0000 (UTC) Received: (qmail 69206 invoked by uid 500); 25 Jun 2012 22:22:46 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 69154 invoked by uid 500); 25 Jun 2012 22:22:46 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 69057 invoked by uid 99); 25 Jun 2012 22:22:46 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2012 22:22:45 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id E06D31418F1 for ; Mon, 25 Jun 2012 22:22:45 +0000 (UTC) Date: Mon, 25 Jun 2012 22:22:45 +0000 (UTC) From: "Hudson (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: <468750088.53832.1340662965921.JavaMail.jiratomcat@issues-vm> In-Reply-To: <25118748.273701296248684549.JavaMail.jira@thor> Subject: [jira] [Commented] (MAPREDUCE-2289) Permissions race can make getStagingDir fail on local filesystem MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400972#comment-13400972 ] Hudson commented on MAPREDUCE-2289: ----------------------------------- Integrated in Hadoop-Hdfs-trunk-Commit #2456 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2456/]) MAPREDUCE-2289. Permissions race can make getStagingDir fail on local filesystem (ahmed via tucu) (Revision 1353750) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1353750 Files : * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmissionFiles.java > Permissions race can make getStagingDir fail on local filesystem > ---------------------------------------------------------------- > > Key: MAPREDUCE-2289 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2289 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: job submission > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Ahmed Radwan > Fix For: 1.1.0, 2.0.1-alpha > > Attachments: MAPREDUCE-2289_branch-1.0.patch, MAPREDUCE-2289_trunk.patch, mapreduce-2289.txt > > > I've observed the following race condition in TestFairSchedulerSystem which uses a MiniMRCluster on top of RawLocalFileSystem: > - two threads call getStagingDir at the same time > - Thread A checks fs.exists(stagingArea) and sees false > -- Calls mkdirs(stagingArea, JOB_DIR_PERMISSIONS) > --- mkdirs calls the Java mkdir API which makes the file with umask-based permissions > - Thread B runs, checks fs.exists(stagingArea) and sees true > -- checks permissions, sees the default permissions, and throws IOE > - Thread A resumes and sets correct permissions -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira