hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Mitic (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4260) Investigate use of JobObject to spawn tasks on Windows
Date Mon, 11 Jun 2012 21:23:42 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293094#comment-13293094
] 

Ivan Mitic commented on MAPREDUCE-4260:
---------------------------------------

Thanks Bikas! Just two minor suggestions/comments:

1.task.c: You will have to {{CloseHandle(jobObject)}} if procList is NULL, right? Also, no
need to ReportErrorCode, as the error is reported on the call site.
2.task.c: I see a mix of tabs and spaces in the file, would you mind switching everything
to spaces?

Otherwise, +1

bq. 1. I agree the check looks a bit weird. But I put that in because I am not sure how this
will affect existing Cygwin installations where people may not have winutils built. I think
that is something we need to figure out.
I see. This is fine for now. IMO, as long as there are no good justifications for supporting
Cygwin installations, we should not have to worry about that in the long term.
                
> Investigate use of JobObject to spawn tasks on Windows
> ------------------------------------------------------
>
>                 Key: MAPREDUCE-4260
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4260
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: MAPREDUCE-4260.branch-1-win.1.patch, MAPREDUCE-4260.branch-1-win.patch,
MAPREDUCE-4260.patch, test.cpp
>
>
> Currently, the Windows version spawns the task as a normal cmd shell from which other
downstream exe's are spawned. However, this is not bullet proof because if an intermediate
process exits before its child exits, then the parent child process tree relationship cannot
be constructed. Windows has a concept of JobObject that is similar to the setsid behavior
used in Linux. The initial spawned task could be launched within its JobObject. Thereafter,
process termination, memory management etc could be operated on the JobObject.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message