hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj K (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4355) Add JobStatus getJobStatus(JobID) to JobClient.
Date Thu, 21 Jun 2012 06:43:43 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398230#comment-13398230
] 

Devaraj K commented on MAPREDUCE-4355:
--------------------------------------

It is good to have this API. Thanks for providing patch. 

There are few minor comments about the patch

1. Can we get the JobStatus directly from Cluster instance instead of getting the Job instance
and getting the JobStatus from Job instance? In Cluster.java, getJob(JobID jobId) API is getting
the JobStatus and creating the Job instance using the JobStatus, again you are getting the
JobStatus from Job instance.

2. I don't see any use of having the jobid as final.

{code:xml}
+  public JobStatus getJobStatus(final JobID jobid) throws IOException {
{code}

3. Can you rename the jobid variable name to jobId, anyway it is minor you can take the final
decision.
                
> Add JobStatus getJobStatus(JobID) to JobClient.
> -----------------------------------------------
>
>                 Key: MAPREDUCE-4355
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4355
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>          Components: mrv1, mrv2
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: MR-4355_mr1.patch, MR-4355_mr2.patch
>
>
> To read the start-time of a particular job, one should not need to getAllJobs() and iterate
through them.
> getJob(JobID) returns RunningJob, which doesn't hold the job's start time.
> Hence, we need to add getJobStatus(JobID) to the API.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message