hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-4253) Tests for mapreduce-client-core are lying under mapreduce-client-jobclient
Date Tue, 22 May 2012 12:45:40 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Harsh J updated MAPREDUCE-4253:
-------------------------------

    Status: Patch Available  (was: Open)

Thanks for the great dissection and the patch as well!

{code}
[ERROR] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/test/MapredTestDriver.java:[29,31]
cannot find symbol
[ERROR] symbol  : class TestTextInputFormat
[ERROR] location: package org.apache.hadoop.mapred
[ERROR] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/test/MapredTestDriver.java:[70,42]
cannot find symbol
[ERROR] symbol  : class TestTextInputFormat
[ERROR] location: class org.apache.hadoop.test.MapredTestDriver
{code}

For some reason I keep getting this no matter the workarounds I try. Let me try the Hadoop
QA on your patch. I believe it may require jobclient to depend on core due to MapredTestDriver
using classes from that now. That is, something like:

{code}
diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-c
index e3853e9..1d9bc89 100644
--- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-j
+++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-j
@@ -37,6 +37,10 @@
     </dependency>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
+      <artifactId>hadoop-mapreduce-client-core</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-mapreduce-client-shuffle</artifactId>
     </dependency>
     <dependency>
{code}

But may also be my env, so lets try submitting your patch.
                
> Tests for mapreduce-client-core are lying under mapreduce-client-jobclient
> --------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4253
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4253
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: client
>    Affects Versions: 2.0.0
>            Reporter: Harsh J
>         Attachments: MR-4253.1.patch, crossing_project_checker.rb, result.txt
>
>
> Many of the tests for client libs from mapreduce-client-core are lying under mapreduce-client-jobclient.
> We should investigate if this is the right thing to do and if not, move the tests back
into client-core.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message