hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3990) MRBench allows Long-sized input-lines value but parses CLI argument as an Integer
Date Fri, 25 May 2012 12:36:23 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283343#comment-13283343
] 

Harsh J commented on MAPREDUCE-3990:
------------------------------------

Given this patch's trivialness and that it merely enhances the tool rather than do anything
negative, and that it has passed the QA run just fine, I'll commit it in by monday EOD unless
anyone has any objections.

Thanks,
Harsh
                
> MRBench allows Long-sized input-lines value but parses CLI argument as an Integer
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3990
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3990
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>         Attachments: MAPREDUCE-3990.patch
>
>
> MRBench has the following method:
> {code}
> public void generateTextFile(FileSystem fs, Path inputFile, long numLines, Order sortOrder)
{ ... }
> {code}
> The method is already set to accept a long datatype for numLines, for generating very
large amount of data.
> However, in {{MRBench#run(...)}}, the inputLines CLI parameter is parsed via an Integer.parseInt,
causing numbers passed > Integer.MAX_VALUE to throw NumberFormatExceptions as a result.
> The parsing should be Long.parseLong and the inputLines datatype should be switched to
the same type as passed to the method (long).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message