Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9AE569A4A for ; Wed, 11 Apr 2012 20:17:46 +0000 (UTC) Received: (qmail 92620 invoked by uid 500); 11 Apr 2012 20:17:46 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 92544 invoked by uid 500); 11 Apr 2012 20:17:46 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 92514 invoked by uid 99); 11 Apr 2012 20:17:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2012 20:17:46 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2012 20:17:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E4EF5365425 for ; Wed, 11 Apr 2012 20:17:22 +0000 (UTC) Date: Wed, 11 Apr 2012 20:17:22 +0000 (UTC) From: "Siddharth Seth (Commented) (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: <1707028083.14179.1334175442939.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1561943465.23458.1330975438941.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (MAPREDUCE-3972) Locking and exception issues in JobHistory Server. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251890#comment-13251890 ] Siddharth Seth commented on MAPREDUCE-3972: ------------------------------------------- Took a quick look at the patch (still looking). Couple of suggestions - HistoryFileInfo.delete. Should the state be changed to DELETED before the actual delete. Seems like this could cause some problems - maybe the synchronization takes care though. - HistoryFileInfo.loadJob - instead of waiting for the file to be moved to done, it may be better to block the move if it hasn't already started - and respond to user requests faster. - JobListCache.add - if the cache size is exceeded and a move failed on the job to be removed - looks like the list will keep growing ? > Locking and exception issues in JobHistory Server. > -------------------------------------------------- > > Key: MAPREDUCE-3972 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-3972 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: mrv2 > Affects Versions: 0.23.2 > Reporter: Robert Joseph Evans > Assignee: Robert Joseph Evans > Attachments: MR-3972.txt, MR-3972.txt, MR-3972.txt, MR-3972.txt > > > The JobHistory server's locking is inconsistent and wrong in some cases. This is not super critical because the issues would only show up if a job is being cleaned up or moved from intermediate done to done, at the same time it is being parsed into a CompletedJob. However the locking is slowing down the server in some cases, and is a ticking time bomb that needs to be addressed. > As part of this too we need to be sure that the Cleaner and Intermediate to Done migration threads handle exceptions properly. Now it appears that the exception is logged, and the thread just shuts down. This means that the history server could still be up and running for weeks and never remove old jobs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira