hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2548) Log improvements in DBOutputFormat.java and CounterGroup.java
Date Fri, 20 Apr 2012 13:36:40 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258242#comment-13258242
] 

Harsh J commented on MAPREDUCE-2548:
------------------------------------

This change appears fine, but we do not need to stringify exceptions anymore.

A better way would be to {{LOG.warn("Some message regarding the failure here", exceptionObject);}}
and that'd work nicely with the logger.
                
> Log improvements in DBOutputFormat.java and CounterGroup.java
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-2548
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2548
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-2548-1.patch, MAPREDUCE-2548.patch
>
>
> 1. Instead of the printing the stack trace on the console, It can be logged. 
> {code:title=DBOutputFormat.java|borderStyle=solid}
>     
> public void write(K key, V value) throws IOException {
>       try {
>         key.write(statement);
>         statement.addBatch();
>       } catch (SQLException e) {
>         e.printStackTrace();
>       }
>     }
> {code}
> 2. Missing resource information can be logged. 
> {code:title=CounterGroup .java|borderStyle=solid}
> protected CounterGroup(String name) {
>     this.name = name;
>     try {
>       bundle = getResourceBundle(name);
>     }
>     catch (MissingResourceException neverMind) {
>     }
>     displayName = localize("CounterGroupName", name);
>   }
>   private String localize(String key, String defaultValue) {
>     String result = defaultValue;
>     if (bundle != null) {
>       try {
>         result = bundle.getString(key);
>       }
>       catch (MissingResourceException mre) {
>       }
>     }
>     return result;
>   }
> {code}
>     

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message