hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devaraj K (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4110) Fix tests in org.apache.hadoop.mapred.TestMiniMRClasspath & org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
Date Fri, 06 Apr 2012 17:19:23 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248508#comment-13248508
] 

Devaraj K commented on MAPREDUCE-4110:
--------------------------------------

Thanks a lot Bobby for looking into the patch.

{quote}
However, I would prefer to see the tests updated to use the MiniMRYarnCluster instead of the
MiniMRCluster, as these are our own internal tests. If you would prefer to file a separate
JIRA for that I am fine with it.
{quote}
MiniMRCluster internally starts the MiniMRYarnCluster and uses it. I don't think it is required
to change in the test cases explicitly.
\\
\\

{quote}
I am also not really sure that we need TestMiniMRClasspath.testClassPath. There are already
numerous tests that verify that we can run a word count job while setting the classpath. Adding
in another, even though it predates some of the ones currently used, just seems like it would
slow down testing and not improve the overall quality of the unit tests.
{quote}

IMO, better we should have dedicated test for this instead of depending on other tests to
verify. If you feel not really required, please let me know I will remove it and update the
patch.

                
> Fix tests in org.apache.hadoop.mapred.TestMiniMRClasspath & org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4110
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4110
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, test
>    Affects Versions: 2.0.0, 3.0.0
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-4110.patch
>
>
> Sub Project : *hadoop-mapreduce-client-jobclient*
> {code:xml}
> Running org.apache.hadoop.mapred.TestMiniMRClasspath
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.032 sec
> {code}
> {code:xml}
> Running org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.031 sec
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message